3021_add_subscriptionMap_log_subscription#3335
Open
ronak4195 wants to merge 5 commits intoredis:masterfrom
Open
3021_add_subscriptionMap_log_subscription#3335ronak4195 wants to merge 5 commits intoredis:masterfrom
ronak4195 wants to merge 5 commits intoredis:masterfrom
Conversation
ndyakov
requested changes
Apr 7, 2025
Member
ndyakov
left a comment
ndyakov
left a comment
There was a problem hiding this comment.
Hello @ronak4195 , would you please add tests. I also failed to see where the subscriptions map will be populated?
Member
|
@ronak4195 kind reminder for adding tests here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add subscriptions map to channel stuct.
This will resolve datatype mismatch in logger of pubsub.go file